Fix ffmpeg dependency and don't import project in setup.py #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalvdans
reviewed
Dec 17, 2022
| @@ -1,6 +1,6 @@ | |||
| from setuptools import setup, find_packages | |||
| import pathlib | |||
| from gpmf import __version__ | |||
| __version__ = "0.1" | |||
There was a problem hiding this comment.
Great! Remove the __version__ definition in gpmf/__init__.py too so we don't have duplicate definitions that risk being out of sync.
kalvdans
approved these changes
Dec 17, 2022
|
@kalvdans do you have write access to the original repository? |
No, sorry. I can't merge, just helping out reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1.
Also it's a bad practice to import the project in setup.py, as at the time of setup the environment likely doesn't have the required dependencies like numpy. There are a couple ways to resolve this while keeping the 2 versions in the same place, see https://packaging.python.org/en/latest/guides/single-sourcing-package-version/.