Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Add support for user attribute "nickname" #108

Closed
wants to merge 5 commits into from

Conversation

tkeber
Copy link

@tkeber tkeber commented Jun 5, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

  • Add support for user attribute nickname.
  • Fix testAccUserCreateUser (username is required property)

Output from acceptance testing:

➜ make testacc TESTS=TestAccUserCreateUser
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./...) -v  -timeout 120m -coverprofile="c.out" -run ^TestAccUserCreateUser
?       github.com/alexkappa/terraform-provider-auth0   [no test files]
=== RUN   TestAccUserCreateUser
--- PASS: TestAccUserCreateUser (0.68s)
PASS
coverage: 11.8% of statements
ok      github.com/alexkappa/terraform-provider-auth0/auth0     0.701s  coverage: 11.8% of statements


...

@lstiebel
Copy link

Hey, just to follow up on this (@tkeber is a colleague of mine), is there anything we can do to assist in getting this merged?

Would allow us to switch back from a fork to the upstream repository.

@alexkappa
Copy link
Owner

@tkeber, @lstiebel, I've rebased and merged this offline. Thank you for submitting this! I am not sure why the build was failing, everything seemed ok to me 🤷‍♂

@alexkappa alexkappa closed this Jun 26, 2019
@alexkappa alexkappa added this to the 0.2.1 milestone Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants