Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Fix Connection's password_dictionary #128

Closed
wants to merge 3 commits into from

Conversation

bishtawi
Copy link
Contributor

@bishtawi bishtawi commented Sep 13, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #127

Changes proposed in this pull request:

  • Turn password_dictionary from just a plain map to a more complex resource that has a enable field (boolean), and dictionary (list of strings).

@alexkappa
Copy link
Owner

Hi @bishtawi, thanks for the submission. Any chance we can pair this with some tests?

@alexkappa
Copy link
Owner

Rebased and merged offline. Thank you!

@alexkappa alexkappa closed this Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password Dictionary option broken on Connection resource
2 participants