Skip to content
This repository has been archived by the owner on Mar 8, 2022. It is now read-only.

Support for Facebook connection provider config #221

Merged

Conversation

relu
Copy link
Contributor

@relu relu commented May 5, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #219

Changes proposed in this pull request:

  • Add support for the Facebook connection provider configuration

Output from acceptance testing:

$ make testacc TESTS=TestAccConnectionFacebook
==> Checking that code complies with gofmt requirements...
?       github.com/terraform-providers/terraform-provider-auth0 [no test files]
=== RUN   TestAccConnectionFacebook
--- PASS: TestAccConnectionFacebook (1.59s)
PASS
coverage: 11.5% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0   1.613s  coverage: 11.5% of statements
?       github.com/terraform-providers/terraform-provider-auth0/auth0/internal/debug    [no test files]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0/internal/random   0.013s  coverage: 0.0% of statements [no tests to run]
testing: warning: no tests to run
PASS
coverage: 0.0% of statements
ok      github.com/terraform-providers/terraform-provider-auth0/auth0/internal/validation       0.002s  coverage: 0.0% of statements [no tests to run]
?       github.com/terraform-providers/terraform-provider-auth0/version [no test files]

Copy link
Owner

@alexkappa alexkappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @relu!

I just merged the Apple connection which exposed certain bugs I had with the scopes field. If you rebase on the latest master you should get those changes in (also updates the sdk).

resource.TestCheckResourceAttr("auth0_connection.facebook", "options.0.scopes.3590537325", "public_profile"),
resource.TestCheckResourceAttr("auth0_connection.facebook", "options.0.scopes.881205744", "email"),
),
},
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add another step so we can test the update operation?


* `client_id` - (Optional) String. Corresponds to the Facebook application ID.
* `client_secret` - (Optional) String, Case-sensitive. The Facebook application client secret.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ;)

@alexkappa alexkappa merged commit 95b8035 into alexkappa:master May 7, 2020
@alexkappa
Copy link
Owner

Thank you @relu!

@relu relu deleted the facebook-connection-provider-support branch May 7, 2020 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of support for some connection providers options
2 participants