GitHub Action to build for macOS #271
Conversation
| run: brew install automake coreutils ffmpeg wxwidgets | ||
| - name : symlink wxwin.m4 | ||
| run: find /usr/local/Cellar/wxwidgets/ -name "wxwin.m4" -exec ln -s {} /usr/local/share/aclocal/wxwin.m4 \; | ||
| - name: autogen |
There was a problem hiding this comment.
you can actually run all these lines together, like this https://github.com/alexkay/spek/pull/268/files#diff-ec943e7e17a4e6a51aa0dd98515f3c31fabb7172a37eba9ccb06cb124768f051R66-R77
There was a problem hiding this comment.
Thank you for your reminder. But, I will keep them separate.
| - name: Upload binary | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: binary-${{ matrix.runner }} |
There was a problem hiding this comment.
it's best to name your output binary ZIP to be more descriptive https://github.com/alexkay/spek/pull/268/files#diff-ec943e7e17a4e6a51aa0dd98515f3c31fabb7172a37eba9ccb06cb124768f051R149
There was a problem hiding this comment.
What is GH?
What is ${{ github.repository_owner }}?
What is ${{ env.short_sha }}?
What name do you suggest?
There was a problem hiding this comment.
i just named it GH for github... but the rest are variables
It is my first time to use GitHub Action. I am still learning how to use it. It is the first version for building on macOS.