-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add DeepThunk #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this file involves some pretty dense Category Theory and many abstractions. Due to my limited knowledge of Category Theory, I don't really understand what's going on in this file, but I will cautiously approve this nonetheless.
Reviewing code you don't understand can be a bit intimidating, but nonetheless having you look over it is very valuable! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice construction! I don't quite follow what the docstrings are saying, which probably means they could use some more love.
I like that you wrote a detailed intro, it's a complicated construction so having the context at the start is really nice!
c742a6b
to
da2df62
Compare
Fixed the comments, feel free to take a look when you have time @alexkeizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/-! | ||
# DeepThunk | ||
|
||
`DeepThunk` corresponds approximately to the [trace](https://ncatlab.org/nlab/show/traced+monoidal+category) of a given polynomial functor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if adding a link to ncatlab make the code more approachable (it's good to have references!) or less (people tend to be intimidated by ncat 🤣). Thanks for adding it, though, I guess ncat is the canonical source for categorical nonsense
DeepThunk
corresponds to the (co-)trace of a given polynomial functor, here we add the natural transformation required to generate them. These will later be used to inject into when generating syntax forcodef
syntax.This commit simply adds the code without using it.