This repository has been archived by the owner on May 14, 2020. It is now read-only.
Create a container for JSONArrow for easier clickability/UX #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any interest in this? I think it's a large usability gain |
chibicode
added a commit
that referenced
this pull request
Mar 17, 2016
Create a container for JSONArrow for easier clickability/UX
|
@axelson great work, thank you! |
|
Published as |
|
@chibicode thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using redux dev tools (via the extension) for a couple weeks now and it's always been overly difficult to click on the JSONArrow to expand/collapse the node. It is only after inspecting the extensions that I realized that you can click on the label as well.
Previously it was difficult to tell that you could click on the label because there is no visual indicator that you can click on it. Ideally there would be an actual visual change as well but inline styles don't support
:hoverso it doesn't appear to be possible to me without changing how this project is structured or consumed (or with mouseover/mouseout which was too invasive for this first change).So the solution I developed was to add a container with padding to JSONArrow and add
cursor: pointer. I believe that this will help the usability of react-json-tree and redux dev tools.