Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DuckDuckGo for search and fix typo in remove history dialogue #37

Merged

Conversation

cortadocodes
Copy link
Contributor

Hi @alexmercerind, thanks for your work creating Audire! I love the app and noticed a couple of things I wanted to suggest as a change (up to you of course though):

  • Switching to DuckDuckGo for music search instead of Google - this would be great as Audire seems to be a privacy-friendly FOSS app, so it would be great to use a private search engine. I considered Brave Search too but wondered if it was too niche at this point
  • I noticed the word "remove" was missing in the "remove history" dialogue so I added it in

Let me know what you think!

@cortadocodes cortadocodes changed the title Use DuckDuckGo for search and fix typo in remove history diaglogue Use DuckDuckGo for search and fix typo in remove history dialogue Sep 6, 2024
Copy link
Owner

@alexmercerind alexmercerind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks a lot.

@alexmercerind alexmercerind merged commit a539c34 into alexmercerind:main Sep 6, 2024
1 check failed
@cortadocodes cortadocodes deleted the use-duckduckgo-for-search branch September 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants