Override name
field in custom Error classes
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, first of all thank you much for your great open-source projects. I am working on a personal project which uses Pyodide and your libraries are truly helpful.
This PR adds overriding of
name
field to custom Error classes -InterruptError
andNoChannelError
.When an error object is thrown from JavaScript to Python, it is converted into
JsException
object and its field values are lost (except for.name
and.message
). Therefore from Python side, it is impossible to tell which type of error is thrown.I thought that replacing
type
field withname
field is more idiomatic (and maybe this is what you intended originally?), however this would be a breaking change.