Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tree-sitter part to latest upstream release "v0.22.6" #91

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fapdash
Copy link
Contributor

@fapdash fapdash commented Jun 22, 2024

Closes #89

@fapdash
Copy link
Contributor Author

fapdash commented Jun 23, 2024

@fmqa Can you please verify that this fixes your problem by following https://github.com/alexmurray/emacs-snap?tab=readme-ov-file#build-it-yourself?

@alexmurray
Copy link
Owner

Thanks for this but as far as I know upgrading tree-sitter may break the use of tree-sitter modules that folks are using - ie. if they have already compiled a tree-sitter module and we upgrade tree-sitter in emacs to a newer version, they would need to recompile their modules - can you confirm if this is expected to work with the older version of tree-sitter as we currently use in the emacs snap?

@alexmurray
Copy link
Owner

Ok I have just done a local test rebuild which includes this new tree-sitter version and it appears to work with the existing modules that I had compiled locally.

@alexmurray
Copy link
Owner

Now that we have 29.4 with the older tree-sitter in the stable channel, I will merge this and let it sit in the beta channel for a bit to get some testing before we go and publish it to stable.

@alexmurray alexmurray merged commit 176061e into alexmurray:master Jun 24, 2024
1 check passed
@fmqa
Copy link

fmqa commented Jun 24, 2024

@fapdash @alexmurray Thanks for the PR+Merge & sorry for the delayed reply. I have actually tested this change a while ago with the tree-sitter modes I use and it works as expected. FWIW, I only use go-ts-mode and gomod-ts-mode but I believe it should work with all other tree-sitter modes too.

Re: Recompiling tree-sitter modules – this might indeed become a recurring problem, since tree-sitter unfortunately lacks a stable ABI. In this case luckily it seems only forward-compatibility was affected, but rebuilding with a newer tree-sitter may be again required if tree-sitter breaks ABI in a future release.

@fapdash
Copy link
Contributor Author

fapdash commented Jun 24, 2024

@fmqa Thank you :)

@alexmurray I installed from the beta channel and could use css-ts-mode without recompiling the module.

@fapdash fapdash deleted the tree-sitter-0.22.6 branch June 24, 2024 13:40
@alexmurray
Copy link
Owner

Thanks for the confirmation - I just promoted this to the stable channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tree-sitter for compatibility with newer tree-sitter grammars
3 participants