Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ability to edit more field #56

Closed
ylxb2016 opened this issue Mar 25, 2022 · 7 comments · Fixed by #64
Closed

Feature request: ability to edit more field #56

ylxb2016 opened this issue Mar 25, 2022 · 7 comments · Fixed by #64
Assignees
Labels
enhancement New feature or request

Comments

@ylxb2016
Copy link

ylxb2016 commented Mar 25, 2022

Hi, alexpdev.

It's an awesome tool which you create!

Generally, we can edit those 8 fields with torrentfileQt:
image

but it's far from enough, it would be great if torrentfileQt could edit every field, like Bencode Editor or torrent-file-editor, including to create/delete/order/search/replace values.

For example:

image

Thanks your effort! 👍 ❤️

@alexpdev alexpdev self-assigned this Mar 26, 2022
@alexpdev alexpdev added the enhancement New feature or request label Mar 26, 2022
@alexpdev
Copy link
Owner

Thanks for the feedback! I will add it to the TODO list

@ylxb2016
Copy link
Author

Thanks!
Also it would be perfect if we can edit torrent via dragging and dropping torrent on it. 👍

alexpdev added a commit that referenced this issue Mar 27, 2022
@alexpdev alexpdev added this to the Bencode Editor milestone Mar 27, 2022
@alexpdev alexpdev mentioned this issue Mar 27, 2022
@alexpdev
Copy link
Owner

I have opened a new branch to work on this issue and have already started making headway.

One of the issues I have, which is why the current editor is so limited, is that there are only a couple of values that you can edit without making the torrent file invalid. Any manipulations to piece size, file paths, file sizes, the ordering of the files, or the piece hashes themselves would render the entire file invalid.

I'm curious what purpose you might have for editing any of those fields?

@ylxb2016
Copy link
Author

ylxb2016 commented Mar 28, 2022

wow, thanks your quick response! ❤️

lol, about the purpose for editing any of those fields, it's common when you upload/cross-seed at various trackers.

They may have different requirements, so you have to edit/modify the torrents to meet their demand. Otherwise, you need to hash a new torrent, which is a really time comsuming and disk hurting stuff when your PC are runing a lot of services.

@alexpdev alexpdev linked a pull request Mar 29, 2022 that will close this issue
@alexpdev
Copy link
Owner

So I haven't finished the bencode editor, that part might take a while, but I have made significant updates to the current torrent editor tab, and implemented the Drag and Drop feature as well. Hopefully this will do for now.

@alexpdev alexpdev reopened this Mar 30, 2022
@ylxb2016
Copy link
Author

Great! It works. 👍

@alexpdev
Copy link
Owner

Great... Ive already found a few bugs here and there so check back once in while to for updates. And if you find one yourself feel free to open another issue.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants