Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elimination of a feature: In-window output #43

Closed
alfongj opened this issue Aug 3, 2011 · 1 comment
Closed

Elimination of a feature: In-window output #43

alfongj opened this issue Aug 3, 2011 · 1 comment
Assignees

Comments

@alfongj
Copy link
Owner

alfongj commented Aug 3, 2011

In-window output has been left out, for some versions now, to show only when the user has pop-ups blocked, and chooses to use this output because he doesn't have any other option. The reason behind that was that the new output through pop-up fits well with the 'Expand' feature, and also is better for printing/saving, etc.

However, keeping this in-window possibility implies, as it is stated before, checking whether the browser has pop-ups allowed or not, which is not a trivial thing to do: It is not standarized, and it doesn't even work in some browsers at all. Moreover, as browsers get updated, they will probably also keep changing the way that you should check on them this (at least Chrome has done so at least 2 or 3 times), so that would mean constant maintenance of this part of GTE.

For those reasons, I suggest eliminating the in-window output and all the popup-allowance checking it implies.

As a replacement for people who don't have popups allowed, some things have to be done:

  • Alert the user that he needs popups enabled, via a Log.HINT, and possibly also via the label shown when hovering over the 'Run' button.
  • Make a new system for people who aren't capable of enabling popups, or dont want to, that shows the output in a Flash internal pop-up instead. This would be as useful as the In-window output, but without the inconveniences of the window resizing and the popup checking.
alfongj added a commit that referenced this issue Aug 3, 2011
@ghost ghost assigned alfongj Aug 3, 2011
@alfongj
Copy link
Owner Author

alfongj commented Aug 3, 2011

Done in 72b2c41

The functionality has been removed from builder.jsp, and alerts have been given as it was suggested in the Issue text.

@alfongj alfongj closed this as completed Aug 3, 2011
alfongj pushed a commit that referenced this issue Mar 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant