Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase log level #849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

naglis
Copy link
Contributor

@naglis naglis commented Oct 12, 2024

Currently all requests/responses are logged on Info level, which is a bit verbose IMHO (no such messages are logged at Info level in 2.x).

If this was intended while 3.0 is in RC stage please feel free to close 😳

Currently all requests/responses are logged on Info level.
@algesten
Copy link
Owner

This was indeed a deliberate change. I liked that I can use the INFO level as "headlines" and then DEBUG/TRACE as details of what happens after that headline.

I don't know what recommendations are though. Is it too chatty?

[2024-10-12T16:53:35Z DEBUG hoot::client::flow] Flow<Prepare>
[2024-10-12T16:53:35Z INFO  ureq::run] GET http://httpbin.org/get
[2024-10-12T16:53:35Z DEBUG ureq::resolver] Resolved: ArrayVec { len: 2, arr: [52.201.182.122:80, 107.22.40.220:80, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0] }
[2024-10-12T16:53:35Z DEBUG ureq::transport::tcp] Connected TcpStream to 52.201.182.122:80
[2024-10-12T16:53:35Z DEBUG hoot::client::flow] Flow<SendRequest>
[2024-10-12T16:53:35Z INFO  ureq::run] Request { method: GET, uri: http://httpbin.org/get, version: HTTP/1.1, headers: {"accept-encoding": "gzip", "user-agent": "ureq/3.0.0-rc1", "accept": "*/*", "host": "httpbin.org"} }
[2024-10-12T16:53:35Z DEBUG hoot::client::flow] Flow<RecvResponse>
[2024-10-12T16:53:35Z DEBUG hoot::client::flow] Flow<RecvBody>
[2024-10-12T16:53:35Z INFO  ureq::run] Response { status: 200, version: HTTP/1.1, headers: {"date": "Sat, 12 Oct 2024 16:53:35 GMT", "content-type": "application/json", "content-length": "290", "connection": "keep-alive", "server": "gunicorn/19.9.0", "<NOTICE>": "2 HEADERS ARE REDACTED"} }
[2024-10-12T16:53:35Z DEBUG hoot::client::flow] Flow<Cleanup>
[2024-10-12T16:53:35Z DEBUG ureq::pool] Pool gone: PoolKey { scheme: "http", authority: httpbin.org, proxy: None }

@algesten
Copy link
Owner

On a side note, that 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0... needs fixing in ArrayVec.

@algesten
Copy link
Owner

On a side note, that 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0, 0.0.0.0:0... needs fixing in ArrayVec.

Sorted in #851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants