Redirect history #939
Merged
Redirect history #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
requested changes
Jan 16, 2025
There was a problem hiding this comment.
Hi @harmless-tech, and welcome to ureq!
Thanks for looking at this. Overall looks great. Some small comments about naming etc. One question about signature.
harmless-tech
force-pushed
the
redirect-history
branch
from
00ee6dd to
ea20c10
Compare
harmless-tech
force-pushed
the
redirect-history
branch
from
ea20c10 to
e7758fd
Compare
algesten
approved these changes
Jan 17, 2025
|
Thank you very much for taking this on! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#731
Adds the option
.save_redirect_history(bool)to the config.When true the function
get_redirect_history()on theResponseExttrait returns aSome(&[Uri])which will contain the request, any redirects, and the final uris.When false
get_redirect_history()returnsNone.