check-if-else in prefer-consitional-expression

[benoitdemaegdt]

The check-if-else option is kind of weird. I may be missing something, but this code is raising an error :

let level = '';
if (process.env.NODE_ENV === 'test') {
  level = 'emerg';
} else if (process.env.NODE_ENV === 'development') {
  level = 'debug';
} else {
  level = 'info';
}

According to this github issue : palantir/tslint#2899
The right way to do it (when using the check-if-else option) is to use ternary operators :

level = (process.env.NODE_ENV === 'test')
  ? 'emerg'
  : (process.env.NODE_ENV === 'development')
    ? 'debug'
    : 'info';

I do not like this syntax. The rule should only raise an error when there is only one else. Example :

if (process.env.NODE_ENV === 'test') {
  level = 'emerg';
} else {
  level = 'debug'
}

[ccoeurderoy]

Use a switch statement instead of if...else if...else:

let level = '';
const NODE_ENV = process.env.NODE_ENV;
switch (NODE_ENV) {
  case 'test':
  level = 'emerg';
  break;

  case 'development':
  level = 'debug';
  break;
  
  default:
  level = 'info';
  break;
}

No need to change this rule.

[benoitdemaegdt]

use switch instead