Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add customIdentifier to the url #30

Merged

Conversation

meriamBenSassi
Copy link
Collaborator

Description

  • Add the customIdentifier as a query param of the aspsp_callback_uri

@meriamBenSassi meriamBenSassi merged commit 27a4b13 into algoan:master Nov 13, 2023
2 checks passed
@@ -46,7 +47,7 @@ export class LinxoConnectLinkService {

const widgetSessionParams: WidgetSessionUrlArgs = {
redirect_url: callbackUrl,
aspsp_callback_uri: connectionUrl,
aspsp_callback_uri: `${connectionUrl}?customIdentifier=${customIdentifier}`,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If instead of the customIdentifier you passed the customerId, this query would be simpler, no ?
https://github.com/meriamBenSassi/api-bff/blob/e32908b7aad0634a66a38c8dab70e0348f9f5b52/src/algoan-connect/algoan-connect.service.ts#L418-L420

@algoanbot
Copy link
Collaborator

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants