fix: don't require searchable facets for popular categories #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
htuzel
approved these changes
Oct 13, 2024
sbellone
added a commit
that referenced
this pull request
Oct 14, 2024
If you currently run the demo without Recommend, the popup doesn't display because the recommend index isn't found. Since Recommend is complex to setup, I propose to not rely on it by default, so anyone can run the demo more easily. This PR uses the same approach than #31 to fetch the most popular `brand` facets from the search results. I'm also leaving the recommend code commented to give pointer about how to integrate Recommend. Note: since our demo index is not fully trained, this approach actually works better: - the current demo displays `Lacy-D`, `Arlene` and `Lacy-S` - locally I now get `Apple`, `Sony`, `Lacy-D` and `Garmin` --- SFCC-390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getAlgoliaFacetsfunction requires the targeted facet to be searchable.Since it's not a requirement for our SFRA cartridge, if people try the demo on their existing index, they would get the following error and the search results wouldn't appear:
Algolia has a way to get the facets and their count that doesn't require to have searchable facets: https://www.algolia.com/doc/guides/managing-results/refine-results/faceting/#retrieving-facets
This PR uses this method to retrieve the facets.
The
resultsobject contains the following object:[{ "facets": { "__primary_category.1": { "Mens > Clothing": 490, "Womens > Accessories": 91, // ... } }, // ... }]The
transformResponsefunction transform it into a sorted array of{ label: int, count: int }objects, like thegetAlgoliaFacetswas doing.SFCC-388