chore(circleci): split unit/integration tests #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladislavFitz
approved these changes
Aug 29, 2022
|
LGTM, I changed the required checks, feel free to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
This PR split the unit tests and the integration tests in CircleCI into dedicated jobs:
unit-tests&integration-tests.What problem is this fixing?
The
integrations-testsrequire credentials, and those credentials are NOT forwarded to fork pull requests. It means that ALL pull requests made by any external contributor is failing from the CI point of view. The idea is to disable the integrations tests suite on fork pull request because anyway they won't pass (see CircleCI documentation).Next steps
We have to change the required checks from
test-1.XXtounit-tests-1.XX. The integration tests become optional but since they cannot run on every PRs anyway it makes no sense to have them required. If they are failing it's our responsibility to check the output.