fix(recommend): export recommend methods to use them in algoliasearch #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
force-pushed
the
fix/recommend-methods-exports
branch
from
db0ab1d
to
6e7e587
Compare
shortcuts
approved these changes
Mar 26, 2024
renovate bot
added a commit
to simonknittel/sinister-incorporated
that referenced
this pull request
Apr 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [algoliasearch](https://github.com/algolia/algoliasearch-client-javascript) | [`4.22.1` -> `4.23.2`](https://renovatebot.com/diffs/npm/algoliasearch/4.22.1/4.23.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>algolia/algoliasearch-client-javascript (algoliasearch)</summary> ### [`v4.23.2`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4232) [Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.1...4.23.2) - fix(recommend): only export default function ([#​1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514)) ([4a04d8e](https://github.com/algolia/algoliasearch-client-javascript/commits/4a04d8e)), closes [#​1514](https://github.com/algolia/algoliasearch-client-javascript/issues/1514) ### [`v4.23.1`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4231) [Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.23.0...4.23.1) - fix(recommend): export recommend methods to use them in algoliasearch ([#​1512](https://github.com/algolia/algoliasearch-client-javascript/issues/1512)) ([5fc5f4f](http://algolia/algoliasearch-client-javascript/commits/5fc5f4f)), closes [#​1512](http://algolia/algoliasearch-client-javascript/issues/1512) ### [`v4.23.0`](https://github.com/algolia/algoliasearch-client-javascript/blob/HEAD/CHANGELOG.md#v4230) [Compare Source](https://github.com/algolia/algoliasearch-client-javascript/compare/4.22.1...4.23.0) - feat(search): fetch recommendations directly from algoliasearch ([#​1509](https://github.com/algolia/algoliasearch-client-javascript/issues/1509)) ([8087b28](http://algolia/algoliasearch-client-javascript/commits/8087b28)), closes [#​1509](http://algolia/algoliasearch-client-javascript/issues/1509) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/simonknittel/sinister-incorporated). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8087b28, we import methods from
@algolia/recommendintoalgoliasearchto give direct access to recommendations from the search client.The CJS bundle for
@algolia/recommenddid not export the methods, only therecommend()method to set up a recommend client. This caused an issue in the v4.23.0 release ofalgoliasearchas it basically imported undefined methods, which prevented the correct instantiation of the search client.This PR reexports all methods to ensure they are present when imported by
algoliasearch.It also tests the built algoliasearch bundles, inspired by what we have in InstantSearch.
Fixes #1511