fix: prevent KeyError when popping an unknown property (#552)

* fix: prevent KeyError when popping an unknown property * fix: typo in version range for mypy
algolia · Jan 3, 2023 · 643eb0f · 643eb0f
1 parent 6dbdf10
commit 643eb0f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/algoliasearch/iterators.py b/algoliasearch/iterators.py
@@ -56,7 +56,8 @@ def __next__(self):
             if len(self._raw_response["hits"]):
                 hit = self._raw_response["hits"].pop(0)
 
-                hit.pop("_highlightResult")
+                if "_highlightResult" in hit:
+                    hit.pop("_highlightResult")
 
                 return hit
 

diff --git a/algoliasearch/iterators_async.py b/algoliasearch/iterators_async.py
@@ -37,7 +37,8 @@ def __anext__(self):  # type: ignore
             if len(self._raw_response["hits"]):
                 hit = self._raw_response["hits"].pop(0)
 
-                hit.pop("_highlightResult")
+                if "_highlightResult" in hit:
+                    hit.pop("_highlightResult")
 
                 return hit
 

diff --git a/tox.ini b/tox.ini
@@ -13,7 +13,7 @@ typing = >=3.6,<4.0; python_version < '3.5'
 asyncio = >=3.4,<4.0
 aiohttp = >=2.0,<4.0; python_version >= '3.4.2'
 async_timeout = >=2.0,<4.0
-mypy = >=0.6,<7.0
+mypy = >=0.600,<0.900
 flake8 = ==3.8.3
 black = ==22.3.0
 twine = >=1.13,<2.0