Feat/support proxy #505
Merged
Feat/support proxy #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aseure
force-pushed
the
feat/support-proxy
branch
from
b789157
to
293cc7d
Compare
aseure
force-pushed
the
feat/support-proxy
branch
from
293cc7d
to
e87f5c7
Compare
This commit brings support for user-defined proxy addresses, defined by
the `HTTP_PROXY` or `HTTPS_PROXY` environment variables, or via the
`Config.proxies` dictionnary of the form:
```py
Config.proxies = {
'http: 'https://127.0.0.1:8080',
'https: 'https://127.0.0.1:8080',
}
```
This works for both the `Requester` and the `RequesterAsync`.
aseure
force-pushed
the
feat/support-proxy
branch
2 times, most recently
from
35a813f
to
6201a36
Compare
TomKlotzPro
reviewed
Aug 6, 2020
| @@ -37,7 +37,7 @@ def send(self, request): | |||
|
|
|||
| try: | |||
| response = self._session.send( # type: ignore | |||
| r, timeout=requests_timeout | |||
| r, timeout=requests_timeout, proxies=request.proxies, | |||
There was a problem hiding this comment.
I recommend having this format to have a better readability.
Suggested change
| r, timeout=requests_timeout, proxies=request.proxies, | |
| r, | |
| timeout=requests_timeout, | |
| proxies=request.proxies, |
There was a problem hiding this comment.
Thanks for the recommendation buddy!
Regarding the formatting, I suggest to work on that in a different PR. For now, it seems that the formatting is losely enforced by a (too?) lightweight flake8 configuration. IMHO we should enforce a stricter flake8 or black configuration to avoid any formatting discussion in the future.
Let me know what you think about this, and let's make this happen soon.
TomKlotzPro
previously approved these changes
Aug 6, 2020
aseure
force-pushed
the
feat/support-proxy
branch
2 times, most recently
from
cf3723a
to
2439aed
Compare
aseure
force-pushed
the
feat/support-proxy
branch
from
2439aed
to
9541c05
Compare
shortcuts
pushed a commit
that referenced
this pull request
Nov 24, 2023
* chore(cts): update dependency on cts generation for java * chore: remove getPackageDependencies from the base class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit brings support for user-defined proxy addresses, defined by
the
HTTP_PROXYorHTTPS_PROXYenvironment variables, or via theConfig.proxiesdictionnary of the form:This works for both the
Requesterand theRequesterAsync.