Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): containerize repo #538

Merged
merged 2 commits into from
Sep 28, 2021
Merged

chore(docker): containerize repo #538

merged 2 commits into from
Sep 28, 2021

Conversation

shortcuts
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fixes #517

Describe your change

Add a Dockerfile and a guide to setup Docker for the repository

What problem is this fixing?

Ease contributions to the Python client

How to test?

  • Follow README steps
  • In image's bash run
    • tox -e format to run linter check
    • tox -e types to run type check
    • tox -e py38-sync,py38-async to run tests for Python 3.8

Copy link
Contributor

@DevinCodes DevinCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left 2 comments, after which I think it's good to go! 🚀

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@DevinCodes DevinCodes merged commit 91c60a3 into master Sep 28, 2021
@shortcuts shortcuts deleted the chore/dockerize-repo branch September 28, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerize repository
2 participants