Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove highlightResult from response #337

Merged
merged 4 commits into from
Dec 24, 2024
Merged

fix: remove highlightResult from response #337

merged 4 commits into from
Dec 24, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Dec 24, 2024

🧭 What and Why

🎟 Related Issue:

Changes included:

there is a regression in the new api clients, we don't remove the highlightResult anymore of the returned objects from the browse response.

in the meantime of a fix there, we can fix it in the integration to prevent different behaviors, as the API doesn't allow saving rules with highlightResult

@shortcuts shortcuts self-assigned this Dec 24, 2024
@shortcuts shortcuts marked this pull request as ready for review December 24, 2024 14:13
Copy link

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo evil laugh

@shortcuts shortcuts merged commit e869b15 into master Dec 24, 2024
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants