refactor(searchOnce): use object vs list of arguments (#681)

algolia · May 7, 2019 · 36066f3 · 36066f3
1 parent fa57274
commit 36066f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/src/algoliasearch.helper.js b/src/algoliasearch.helper.js
@@ -202,7 +202,9 @@ AlgoliaSearchHelper.prototype.searchOnce = function(options, cb) {
 
   this._currentNbQueries++;
 
-  this.emit('searchOnce', tempState);
+  this.emit('searchOnce', {
+    state: tempState
+  });
 
   if (cb) {
     this.client

diff --git a/test/spec/algoliasearch.helper/events.js b/test/spec/algoliasearch.helper/events.js
@@ -254,23 +254,25 @@ test('search event should be emitted once when the search is triggered and befor
 });
 
 test('searchOnce event should be emitted once when the search is triggered using searchOnce and before the request is sent', function() {
+  var searchedOnce = jest.fn();
   var fakeClient = makeFakeClient();
   var helper = algoliaSearchHelper(fakeClient, 'Index', {
     disjunctiveFacets: ['city'],
     facets: ['tower']
   });
 
-  var count = 0;
+  helper.on('searchOnce', searchedOnce);
 
-  helper.on('searchOnce', function() {
-    count++;
-  });
-
-  expect(count).toBe(0);
+  expect(searchedOnce).toHaveBeenCalledTimes(0);
   expect(fakeClient.search).toHaveBeenCalledTimes(0);
 
   helper.searchOnce({}, function() {});
-  expect(count).toBe(1);
+
+  expect(searchedOnce).toHaveBeenCalledTimes(1);
+  expect(searchedOnce).toHaveBeenLastCalledWith({
+    state: helper.state
+  });
+
   expect(fakeClient.search).toHaveBeenCalledTimes(1);
 });