This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 46
Make the core model/state of the search (SearchParameter) immutable (for real) #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | ||
* Clear all or parts of a RefinementList. Depending on the arguments, three | ||
* behaviors can happen : | ||
* - if not attribute is provided : clears the whole list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/not/no/
LGTM 👍 |
+ associated test + new found bug in addNumericRefinement
✅ reviewed |
Thanks @vvo @pixelastic |
bobylito
added a commit
that referenced
this pull request
Jun 15, 2015
FIX #14 Make the core model/state of the search (SearchParameter) immutable (for real)
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…eature/mutability FIX algolia/algoliasearch-helper-js#14 Make the core model/state of the search (SearchParameter) immutable (for real)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this pull request is to provide real immutability for the state of the search that is encapsulated into the helper (
helper.state
)In practice, this will help to easily test that the previous state is different from the current by comparing references. It will also help test properties for the future, you can now easily modify the model without having to revert the changes.