refactor(lodash): remove simple functions #656

Haroenv · 2019-04-23T13:25:26Z

isUndefined
isEqual
isNaN
keys
isFunction
isEmpty

src/SearchParameters/RefinementList.js

src/SearchParameters/index.js

src/algoliasearch.helper.js

src/SearchParameters/index.js

src/SearchParameters/RefinementList.js

src/SearchParameters/filterState.js

src/algoliasearch.helper.js

src/SearchParameters/index.js

Co-Authored-By: Haroenv <fingebimus@me.com>

this used to be isEmpty, so here we use a similar, but more focused condition

src/SearchParameters/filterState.js

src/SearchParameters/index.js

src/functions/objectHasKeys.js

* isFunction * keys * isEmpty & isUndefined * isEqual * isNaN * Update src/SearchParameters/index.js Co-Authored-By: Haroenv <fingebimus@me.com> * feedback from review * fix(params): harden conditions for empty refinements this used to be isEmpty, so here we use a similar, but more focused condition * chore(numeric): make helper function clearer * refactor: use created helper method * fix: don't use const * feat(objectHasKeys): return false for falsy (non-object)

* fix(merge): change implementation (#716) 29c2138 * chore: mention remaining changes f756947 * chore(deps): update circleci/node:8.15.1 docker digest to ef1a0c4 (#715) f4dab89 * chore(lodash): remove _.omit (#655) 7db8b4c * chore(lodash): remove lodash from dependency list (#705) a63ec6b, closes #552 * chore(release): allow canary release (#712) 3eb087c * chore(removeHierarchicalFacetRefinement): remove error if not refined (#747) e68ecfe * chore: merge develop into master (#750) 53c7c62 * chore: remove Bower support (#711) e7518e2 * chore(ts): add methods d051f79 * chore(ts): add ruleContexts to SP 4bdc4a4 * chore(ts): add searchOnlyWithDerivedHelpers (#739) c6aa31b * chore(ts): publish definition file too 1813462 * chore(TS): isNumericRefined has only one required argument cac8fc3 * chore(warn): remove unused function (lodash.bind) (#682) c59b7e3 * chore: update release command 0989880 * docs: add link to wiki 3598f2a * docs: update event signature (#701) bbe4634 * docs(migration): mention changed methods (#732) f95e680 * docs(next): add migration guide 8430137 * docs(serverUsed): mention getRankingInfo (#706) f258c2a, closes #500 * feat: implement dedicated reset page method (#673) 666501e * feat(getState): remove filter option (#707) ac52791 * feat(getState): remove getState (#708) 7de698c * feat(requestBuilder): prevent needless extra requests for empty refinements (#737) db0a392 * feat(search): allow the search only with Derived Helpers (#704) aa128fc * feat(SearchParameters): avoid undefined values (#703) 9757e0a * feat(typescript): move typings inline (#719) a12272e * fix(defaults): remove const 48a0c48 * fix(errors): remove isRefined (#731) 5761885 * fix(getConjunctiveRefinements): no error when requested facet is not conjunctive (#724) cf852e7 * fix(getDisjunctiveRefinements): remove error (#725) 211e390 * fix(getExcludeRefinements): replace error by default value (#726) 9d7ae87 * fix(getFacetStats): remove error (#721) 96b6ec8 * fix(getFacetValues): don't throw error when there's no facet (#720) e15e39e * fix(getHierarchicalFacetBreadcrumb): don't throw an error (#723) 40e1d61 * fix(isDisjunctiveFacetRefined): return false if not in disjunctiveFacets (#729) 13ec09b * fix(isExcludeRefined): remove error in favor of false (#728) 3f0ab6b * fix(isFacetRefined): return false if facet isn't declared (#727) 7151f56 * fix(isHierarchicalFacetRefined): return false if refinement isn't a facet (#730) 89fa010 * fix(lodash/intersection): replace with custom implementation (#718) 00dfb4e * fix(removeXFacet): make sure this fully removes empty arrays (#743) ea5a22a * fix(results): remove lodash looping over objects (#648) bb025c2, closes #258 * fix(sortBy): compare whole prefix instead of first character (#702) b85fb50, closes #702 * fix(toggleRefinement): keep an empty array when clearing (#738) 5b3fc11 * fix(types): add state.removeNumericRefinement (#742) e58c24a * refactor(addAgent): remove duplicate code (#657) d023efd * refactor(error): use object vs list of arguments (#700) 722eceb * refactor(lodash): compact (#689) 284efa5 * refactor(lodash): forOwn (#697) eae367a * refactor(lodash): intersection (#696) 25822a5 * refactor(lodash): map & trim (#679) 357fcb7 * refactor(lodash): merge (#694) 92bced4 * refactor(lodash): partial & partialRight (#693) 7ceea2f * refactor(lodash): remove filter (#685) 249d2e6 * refactor(lodash): remove flatten (#695) 9da0e08 * refactor(lodash): remove forEach (#674) 8c93765 * refactor(lodash): remove reduce (#678) 7907805 * refactor(lodash): remove simple functions (#656) c309ffa * refactor(lodash): remove startsWith (#690) bb00933 * refactor(lodash): replace defaults with pure alternative (#692) ee07132 * refactor(lodash): replace find & findIndex (#687) 92e7c23 * refactor(lodash): replace orderBy (#698) bb2b31e * refactor(lodash): sumBy (#688) a538bd9 * refactor(result): use object vs list of arguments (#699) 643f18e * refactor(search): emit object (#683) 46c7d7d * refactor(searchForFacetValues): use object vs list of arguments (#684) ab8e9c5 * refactor: remove getQueryParameter (#713) d9dfac4 * refactor(searchOnce): use object vs list of arguments (#681) 42b40d3 * refactor(SearchParameters): removes default values (#670) b15696b * refactor(url): remove url helpers (#652) 52e22f4 * test(sffv): no longer test impossible responses (#686) fd878e8 ### BREAKING CHANGE * getState(filters) is replaced my manually filtering the returned object * removed helper.isRefined, use helper.hasRefinements instead * SearchParameters.filter is removed * doc(filter): remove reference * use helper.state instead of helper.getState()

…er-js#656) * isFunction * keys * isEmpty & isUndefined * isEqual * isNaN * Update src/SearchParameters/index.js Co-Authored-By: Haroenv <fingebimus@me.com> * feedback from review * fix(params): harden conditions for empty refinements this used to be isEmpty, so here we use a similar, but more focused condition * chore(numeric): make helper function clearer * refactor: use created helper method * fix: don't use const * feat(objectHasKeys): return false for falsy (non-object)

Haroenv requested a review from a team April 23, 2019 13:25

francoischalifour reviewed Apr 23, 2019

View reviewed changes

yannickcr reviewed Apr 23, 2019

View reviewed changes

src/SearchParameters/index.js Outdated Show resolved Hide resolved

Haroenv force-pushed the fix/more-lodash branch from 1c849a2 to a4b2778 Compare April 23, 2019 14:22

Haroenv commented Apr 23, 2019

View reviewed changes

src/SearchParameters/index.js Outdated Show resolved Hide resolved

Haroenv force-pushed the fix/more-lodash branch from 34eda47 to 0ddbbed Compare April 23, 2019 15:12

Haroenv mentioned this pull request Apr 23, 2019

refactor(lodash): remove _.omit #655

Merged

samouss reviewed Apr 29, 2019

View reviewed changes

src/SearchParameters/RefinementList.js Outdated Show resolved Hide resolved

src/SearchParameters/RefinementList.js Outdated Show resolved Hide resolved

Haroenv requested review from francoischalifour, samouss and a team May 2, 2019 13:08

Haroenv changed the title ~~refactor(lodash): remove simple functions~~ refactor(lodash): remove simple functions WIP May 6, 2019

Haroenv added the PR: do not merge label May 6, 2019

tkrugg reviewed May 7, 2019

View reviewed changes

src/SearchParameters/filterState.js Show resolved Hide resolved

tkrugg reviewed May 7, 2019

View reviewed changes

src/algoliasearch.helper.js Outdated Show resolved Hide resolved

tkrugg reviewed May 7, 2019

View reviewed changes

src/SearchParameters/index.js Outdated Show resolved Hide resolved

Haroenv changed the title ~~refactor(lodash): remove simple functions WIP~~ refactor(lodash): remove simple functions May 7, 2019

Haroenv changed the base branch from develop to next May 7, 2019 12:25

Haroenv force-pushed the next branch 3 times, most recently from 053fb1f to ee9a4f5 Compare May 7, 2019 14:20

Haroenv force-pushed the fix/more-lodash branch 2 times, most recently from a3593c4 to b40d2be Compare May 9, 2019 08:38

Haroenv mentioned this pull request May 9, 2019

refactor(lodash): intersection #696

Merged

Haroenv removed the PR: do not merge label May 9, 2019

Haroenv force-pushed the fix/more-lodash branch 2 times, most recently from a17807d to c907865 Compare May 9, 2019 08:57

samouss force-pushed the next branch from 01a5c1a to afe0baa Compare May 9, 2019 10:18

Haroenv added 2 commits May 9, 2019 12:41

isFunction

0c390cc

keys

edeebdf

Haroenv and others added 8 commits May 9, 2019 12:41

isEmpty & isUndefined

d1d36a7

isEqual

3b5fefd

isNaN

18ccb63

Update src/SearchParameters/index.js

23a7d78

Co-Authored-By: Haroenv <fingebimus@me.com>

feedback from review

1be6a00

fix(params): harden conditions for empty refinements

6a3cfe8

this used to be isEmpty, so here we use a similar, but more focused condition

chore(numeric): make helper function clearer

9f6b06b

refactor: use created helper method

cf839ab

Haroenv force-pushed the fix/more-lodash branch from d1b4785 to cf839ab Compare May 9, 2019 10:42

Merge branch 'next' into fix/more-lodash

c59eb77

samouss reviewed May 10, 2019

View reviewed changes

src/SearchParameters/filterState.js Outdated Show resolved Hide resolved

src/SearchParameters/index.js Show resolved Hide resolved

src/SearchParameters/index.js Show resolved Hide resolved

src/functions/objectHasKeys.js Outdated Show resolved Hide resolved

Haroenv and others added 3 commits May 10, 2019 14:45

fix: don't use const

326b39a

feat(objectHasKeys): return false for falsy (non-object)

bc5eb32

Merge branch 'next' into fix/more-lodash

3c9fb07

samouss approved these changes May 10, 2019

View reviewed changes

Haroenv merged commit c78bd0f into next May 10, 2019

Haroenv deleted the fix/more-lodash branch May 10, 2019 13:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(lodash): remove simple functions #656

refactor(lodash): remove simple functions #656

Haroenv commented Apr 23, 2019 •

edited

Loading

refactor(lodash): remove simple functions #656

refactor(lodash): remove simple functions #656

Conversation

Haroenv commented Apr 23, 2019 • edited Loading

Haroenv commented Apr 23, 2019 •

edited

Loading