This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(merge): consider "null" as not an object #709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behaves the same as lodash (but they didn't have a test for it)
Haroenv
commented
May 15, 2019
ghost
requested review from
tkrugg
reviewed
May 15, 2019
tkrugg
reviewed
May 15, 2019
tkrugg
reviewed
May 15, 2019
tkrugg
approved these changes
May 15, 2019
samouss
suggested changes
May 15, 2019
There was a problem hiding this comment.
It does solve the issue with null, but I've tried with InstantSearch and the HierarchicalMenu does not work properly. Multiple levels are opened at the same time with duplicated values. It looks like we share a reference somewhere. I've tried with the merge function of Lodash and the problem is gone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behaves the same as lodash (but they didn't have a test for it)
This fixes the behaviour seen in http://localhost:6006/?path=/story/breadcrumb--with-hierarchical-menu on
refactor/usage-search-parameters(on InstantSearch.js when you link this version of the helper)IFW-777