This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(ts): add types for smart sort #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
reviewed
Feb 9, 2021
Haroenv
reviewed
Feb 9, 2021
index.d.ts
Outdated
| @@ -1156,6 +1166,14 @@ declare namespace algoliasearchHelper { | |||
| * total number of hits of this query on the index | |||
| */ | |||
| nbHits: number; | |||
| /** | |||
| * total number of hits from smart sort | |||
There was a problem hiding this comment.
can we use the same descriptions as in the client? algolia/algoliasearch-client-javascript#1251
There was a problem hiding this comment.
Oh nice, I didn't know they were already there. 107374a
…per-js into fix/smart-sort
Haroenv
reviewed
Feb 9, 2021
| * value means fewer, but more relevant results, smaller value means more, but | ||
| * less relevant results. | ||
| */ | ||
| relevancyStrictness?: number; |
There was a problem hiding this comment.
this one likely isn't needed (although can be useful for v3 support)
There was a problem hiding this comment.
Can you tell me why it's not needed?
When we need to set relevancyStrictness from the frontend side, we will need it, no?
There was a problem hiding this comment.
because the interface inherits from the client type, but in this case we still want to copy it for v3 compact
There was a problem hiding this comment.
Ah got what you mean 👍🏼
Haroenv
approved these changes
Feb 10, 2021
shortcuts
approved these changes
Feb 10, 2021
eunjae-lee
added a commit
that referenced
this pull request
Feb 10, 2021
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* fix(ts): add types for smart sort * chore: update comments
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* chore: update yarn.lock algolia/algoliasearch-helper-js@ba912f9 * fix(ts): add types for smart sort (algolia/algoliasearch-helper-js#809) algolia/algoliasearch-helper-js@7fa7528 * fix(ts): make queryID optional (algolia/algoliasearch-helper-js#806) algolia/algoliasearch-helper-js@5ec4e86
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the following types for smart sort
relevancyStrictnessin the search parameternbSortedHitsandappliedRelevancyStrictnessin the search response