APEX-689: Migrated Algolia libraries to the cartridge #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter, updated Node package versions
sbellone
reviewed
Mar 14, 2023
There was a problem hiding this comment.
This branch is based off of feature/APEX-497
Then you can make it point on that branch instead of master, so the diff doesn't contain changes from the other PR
Otherwise it looks good, only small comments.
(I'm just not convinced by the need to have an extra dependencies to copy a few files)
|
Oh also, there is an error on the CI when installing packages |
from a CDN service, misc. optimizations
ede-somogyi-algolia
force-pushed
the
feature/APEX-689
branch
from
4c13384 to
bb98a9f
Compare
|
…om linting with a single rule
sbellone
reviewed
Mar 15, 2023
cartridges/int_algolia/cartridge/templates/default/algolia/headerScripts.isml
Show resolved
Hide resolved
sbellone
approved these changes
Mar 16, 2023
| attribute: "name", | ||
| tagName: "em" | ||
| })}</a> | ||
| hit: item, |
There was a problem hiding this comment.
This indentation is a bit weird no?
There was a problem hiding this comment.
Fixed indentation.
package.json
Outdated
| "eslint-plugin-jquery": "^1.5.1", | ||
| "eslint-plugin-prettier": "^4.2", | ||
| "hogan.js": "1.0.2", | ||
| "htm": "^3.1.1", |
There was a problem hiding this comment.
Suggested change
| "htm": "^3.1.1", | |
| "htm": "3.1.1", |
There was a problem hiding this comment.
Pinned down version number.
… the version for the htm package
ede-somogyi-algolia
force-pushed
the
feature/APEX-689
branch
from
e4932a6 to
2e87445
Compare
sbellone
approved these changes
Mar 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes from APEX-497 and is pointed to the newly-created
developbranch.Closing down the other PR for clarity and adding the changes here:
Changes from APEX-497:
package.json, removed unnecessary packages;sgmf-scripts);.eslintignore: removed/rewrote some ignored paths;.eslintrc.json;.prettierrcconfig;package.json;Changes from APEX-689:
package.jsonasdevDependenciesand also committed to the repository instead of loading them from a CDNdevDependenciesand committed to the repo (Hogan.js,Preact);.eslintignore'd together;Outstanding issues:
autocomplete-js@1was left as-is because it requiresalgoliasearch@4as a dependency, but the cartridge currently uses v3;algoliasearchto v4 is pending as it is a major version change and as such may contain breaking changes -- will be in the scope of another ticket.