Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APEX-724: Updated SearchInsights to v2 + configured InstantSearch Insights middleware #17

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

ede-somogyi-algolia
Copy link
Contributor

@ede-somogyi-algolia ede-somogyi-algolia commented Mar 27, 2023

  • updated SearchInsights to v2 (1.3.1 => 2.4.0);
  • initialized InstantSearch Insights middleware to have more data points;
  • miscellaneous minor formatting and typo fixes;

@ede-somogyi-algolia ede-somogyi-algolia marked this pull request as ready for review March 27, 2023 14:16
Copy link
Collaborator

@bsuravech bsuravech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the clean up as well!

@ede-somogyi-algolia ede-somogyi-algolia self-assigned this Apr 3, 2023
Copy link
Collaborator

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor suggestions about the comments

@ede-somogyi-algolia ede-somogyi-algolia merged commit 80d5073 into develop Apr 4, 2023
@ede-somogyi-algolia ede-somogyi-algolia deleted the feature/APEX-724 branch April 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants