APEX-714: Some category landing pages don't display any products on load #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… safety checks, fixed typos
sbellone
approved these changes
Apr 4, 2023
cartridges/algolia_sg_changes/cartridge/templates/default/search/simplesearch.isml
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed to trace back the issue to this PR with the original issue being that using jQuery's
data()method to retrieve data attribute recasts the type of the values it finds in the data attribute automatically (if it finds a number, it returns a Number).The proposed solution in PR #10 was to use
attr()instead, which leaves all values as strings.While this fixed the original issue of
data()typecasting number values as Number, it introduced another issue whereby if a data attribute wasnull,attr()returned it as"null"(as string), in some cases causing Algolia to return no search hits (in this case theqparameter was being set to"null").Fixed the issue by outputting an empty string as
data-qwhen the backend returnsnullas its value.Please note that the PR contains changes from APEX-724 and APEX-721 as well, these will disappear from the diff once these PRs are merged.