Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple small fixes #38

Merged
merged 3 commits into from
Aug 2, 2023
Merged

Multiple small fixes #38

merged 3 commits into from
Aug 2, 2023

Conversation

ede-somogyi-algolia
Copy link
Contributor

@ede-somogyi-algolia ede-somogyi-algolia commented Jul 18, 2023 •
edited
Loading

  1. Clarified usage of the newURL object of type URL.
    The old version also works since URL.prototype.toString() returns the href property as well, this just makes the code less ambiguous.
  2. Fixed grammatical and spelling errors
  3. Renamed variables:
  • sendedChunk to sentChunks
  • sendedRecords to sentRecords
  • failedChunk to failedChunks
  • countFailedShunks to countFailedChunks
  • calkMaxNumberOfEntries to calcMaxNumberOfEntries
  1. Reworded BM module text resources to make them clearer

@ede-somogyi-algolia ede-somogyi-algolia marked this pull request as draft July 18, 2023 15:06
@ede-somogyi-algolia ede-somogyi-algolia self-assigned this Jul 18, 2023
@ede-somogyi-algolia ede-somogyi-algolia marked this pull request as ready for review July 18, 2023 15:20
@sbellone
Copy link
Collaborator

Oh you could also add the const updateLogType = 'LastProductSyncLog'; refactor in roductIndexJob.js

@ede-somogyi-algolia
Copy link
Contributor Author

Oh you could also add the const updateLogType = 'LastProductSyncLog'; refactor in roductIndexJob.js

Added changes from productsIndexJob.js and also added the udateLogType to categoryIndexJob.js.

@ede-somogyi-algolia ede-somogyi-algolia merged commit 06ffa25 into develop Aug 2, 2023
@ede-somogyi-algolia ede-somogyi-algolia deleted the fix/20230718-minor-fix branch August 2, 2023 14:05
@ede-somogyi-algolia ede-somogyi-algolia mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbellone sbellone sbellone approved these changes

Assignees

@ede-somogyi-algolia ede-somogyi-algolia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ede-somogyi-algolia @sbellone