SFCC-79: Changed in_stock behavior #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmogos
approved these changes
Aug 3, 2023
ede-somogyi-algolia
changed the title
sbellone
requested changes
Aug 3, 2023
cartridges/int_algolia/cartridge/scripts/algolia/model/algoliaProduct.js
Show resolved
Hide resolved
cartridges/int_algolia/cartridge/scripts/algolia/model/algoliaProduct.js
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
in_stockproperty now exports a boolean indicating whether the actual number of products in stock (ATS or available to sell) is higher than theAlgolia_InStockThresholdcustom site preference, as originally intended.The previous logic was flawed in that it compared the site preference to
product.availabilityModel.availability, which returns a number between 0 and 1, and as such doesn't represent the number of products in stock, thus the comparison always returning false.