This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
feat(search-client): Add support for Custom Search Clients #111
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6ad17d7
feat: Update Client, Helper and InstantSearch
francoischalifour 160e13a
feat: Add support for `searchClient`
francoischalifour 0e09be7
feat(dev-novel): Add `searchClient` support
francoischalifour 2219d85
feat(dev-novel): Add search client stories
francoischalifour e716738
chore: Upgrade instantsearch beta
francoischalifour 5821351
docs: Mention `searchClient` in the docs
francoischalifour e677531
style: Remove trailing comas
francoischalifour e250f84
feat: Change `algoliasearch` import for Rollup
francoischalifour 90ffec0
style: Fix lint
francoischalifour b151eeb
feat: Add SearchClient type
francoischalifour f43fd4c
feat: Add function signature for SearchClient type
francoischalifour 9b15a82
feat: Type SearchClient and SearchParameters
francoischalifour 42b5480
feat: Use SearchParameters type for `searchParameters` option
francoischalifour 1c34e6b
feat: Add `createSSRSearchClient` as a `createSSRAlgoliaClient` alter…
francoischalifour 13ab84b
feat: Export `createSSRSearchClient`
francoischalifour 512d6c7
fix: Lint
francoischalifour File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not want to deprecate this yet, it is still used for the server side rendering strategy:
If we want to get rid of
createAlgoliaClient
we have to support server side rendering as well with the new method.I can help for this 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
createSSRSearchClient()
and deprecatedcreateSSRAlgoliaClient()
. Hope this is how you envisioned it!