Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: assert node helpers #3689

Merged
merged 1 commit into from
Sep 11, 2024
Merged

chore: assert node helpers #3689

merged 1 commit into from
Sep 11, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 11, 2024

🧭 What and Why

🎟 JIRA Ticket: contributes to algolia/algoliasearch-client-javascript#1548

Changes included:

simple assertion to make sure that the methods exists on those builds algolia/algoliasearch-client-javascript#1548 (comment)

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 11, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 99bbe36a3ba6a46c8b86b733de37612bad22462b
🍃 Generated commit c68e9a376fc88f76fb63813771fa99af0d942c30
🌲 Generated branch generated/chore/assert-node-helpers
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1663

Base automatically changed from chore/playground-javascript-browser to main September 11, 2024 12:22
@shortcuts shortcuts marked this pull request as ready for review September 11, 2024 12:28
@shortcuts shortcuts requested a review from a team as a code owner September 11, 2024 12:28
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice

@shortcuts shortcuts merged commit d39b877 into main Sep 11, 2024
12 checks passed
@shortcuts shortcuts deleted the chore/assert-node-helpers branch September 11, 2024 12:44
algolia-bot added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 11, 2024
algolia/api-clients-automation#3689

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants