fix(specs): update analytics and abtesting max pagination query limit #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add details about pagination limit
…cs version of offset and limit
…it to avoid confusion
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
febeck
changed the title
shortcuts
changed the title
shortcuts
approved these changes
Sep 12, 2024
|
should we wait for someone from your team to review as well, or is it good to go? |
|
@shortcuts we need to wait - we had to revert the change and i'll approve when we get it redeployed |
|
Thanks for the review @shortcuts . As @cdhawke said, this change has been reverted and therefore I put the PR in draft |
millotp
approved these changes
Oct 3, 2024
algolia-bot
added a commit
that referenced
this pull request
Oct 3, 2024
…#3696) (generated) [skip ci] Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Oct 3, 2024
… (generated) algolia/api-clients-automation#3696 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Fernando Beck <fe.beck25@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Analytics team is enforcing the limit where combination of
limitandoffsetcan only target the top 1000 rows.Documentation updated to reflect those updates
🎟 JIRA Ticket: OPTIM-1255
Changes included:
LimitandOffsetwere previously defined in a globalcommonfolder. Usages were made in analytics and one single usage in AB test.To avoid any confusion
🧪 Test