Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): allow fork to access secrets #3873

Merged
merged 3 commits into from
Oct 3, 2024
Merged

chore(ci): allow fork to access secrets #3873

merged 3 commits into from
Oct 3, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Oct 3, 2024

🧭 What and Why

To allow external contributors, we need to allow them to access token on the CI, this is safe because we need to approve the CI before it can run.

@millotp millotp self-assigned this Oct 3, 2024
@millotp millotp requested a review from a team as a code owner October 3, 2024 12:09
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 3, 2024

No code generated

If you believe code should've been generated, please, report the issue.

📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1662
php 1490
go 1435
csharp 1318
java 1110
python 1036
ruby 873
swift 760

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@millotp millotp merged commit 0cdb866 into main Oct 3, 2024
28 checks passed
@millotp millotp deleted the chore/allow-fork branch October 3, 2024 14:33
shortcuts added a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants