Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swift): guide gen #3875

Closed
wants to merge 1 commit into from

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Oct 4, 2024

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • one gen per guide template
  • in its own folder
  • with the guide name as a folder name
  • the file name is always main.swift
  • with a gen Package.swift with all the guides
  • each has its own taget
  • so it can build on macos and linux and be copy/pasted by users

@Fluf22 Fluf22 requested a review from a team as a code owner October 4, 2024 12:15
@Fluf22 Fluf22 requested review from morganleroi and millotp and removed request for a team October 4, 2024 12:15
@Fluf22 Fluf22 self-assigned this Oct 4, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 4, 2024

✔️ Code generated!

Name Link
🪓 Triggered by fb9c2ac2ec5ba6fc380ee7c154a998f2b3927ae0
🍃 Generated commit 91ed2a5dac1835fb9ed37ecc5ccb3c16bd2171fb
🌲 Generated branch generated/feat/swift-guide-gen
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1652
go 1554
php 1456
csharp 1310
java 1095
python 1019
ruby 797
swift 727

@Fluf22 Fluf22 force-pushed the feat/swift-guide-gen branch 4 times, most recently from ebe2a07 to 4cfd030 Compare October 4, 2024 12:32
@millotp
Copy link
Collaborator

millotp commented Oct 8, 2024

for now we stick to a more common approach for swift guides, if we to run them in this repo we can come back to this PR

@millotp millotp closed this Oct 8, 2024
@millotp millotp deleted the feat/swift-guide-gen branch October 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants