chore: apply codacy fixes #3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
reviewed
Oct 9, 2024
| @@ -1,6 +1,6 @@ | |||
| module github.com/algolia/algoliasearch-client-go/v4 | |||
|
|
|||
| go 1.21 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Can people using go1.22 still use this lib if we use 1.23 ?
There was a problem hiding this comment.
I think so yes, as long as we don't depend on std introduced in 1.21+
I guess we should add multi version testing to Go too D:
There was a problem hiding this comment.
Just tried it with the CTS: go: module ../../../clients/algoliasearch-client-go requires go >= 1.23 (running go 1.22.8)
There was a problem hiding this comment.
we should stick to a low version
There was a problem hiding this comment.
oki nice then let's keep 1.21 because that's what we settled on at the major release
shortcuts
reviewed
Oct 10, 2024
algolia-bot
added a commit
that referenced
this pull request
Oct 10, 2024
Co-authored-by: Pierre Millot <pierre.millot@algolia.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Oct 10, 2024
algolia/api-clients-automation#3935 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Oct 10, 2024
algolia/api-clients-automation#3935 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Oct 10, 2024
algolia/api-clients-automation#3935 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
We use Codacy to statically analyse the code and find vulnerabilities.