feat(specs): add composition API #4056
Conversation
🪓 The generated code will be pushed at the end of the CI.Action triggered by commit Please do not push any generated code to this pull request. |
|
good @e-krebs everything should work once our testing app has been allowed to use composition, so that our e2e can runs |
is it a metis App ? |
nope, is it required? we could migrate it or make a new one |
yes, it is required. |
ok! i'll be off next week so I guess @millotp will be the point of contact to help setting those for the e2e |
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| index: |
There was a problem hiding this comment.
In the search API and all the other spec, the property for an index name is always called indexName and not just index.
This is just a matter of consistency, I saw that in the composition spec indexName is also used
There was a problem hiding this comment.
I agree in theory, but this property is named index in the API itself, according to the documentation: https://algolia.atlassian.net/wiki/spaces/CMP/pages/5149753345/Models
e-krebs
force-pushed
the
feat/composition-alpha
branch
from
725804d to
ca7bbd8
Compare
Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia/api-clients-automation#4056 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: shortcuts <vannicattec@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
this pr adds a new package for the javascript client, for the composition API. we only provide an alpha version, in javascript for now, and will make it globally available (and in algoliasearch) once the stable version has been reached.