Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): allow import from dist #4060

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Oct 31, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3141

Changes included:

It's impossible to import from the dist right now because it's not defined in the exports

@shortcuts shortcuts self-assigned this Oct 31, 2024
@shortcuts shortcuts requested a review from a team as a code owner October 31, 2024 09:33
@shortcuts shortcuts requested review from Fluf22 and millotp October 31, 2024 09:33
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 31, 2024

✔️ Code generated!

Name Link
🪓 Triggered by b1715123bb4f54723d24f200cb2c2d2447533597
🍃 Generated commit 4e09f8b67deacdabb3c0b00207c6dede931f1bf8
🌲 Generated branch generated/fix/javascript-import-dist
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1623

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shortcuts shortcuts merged commit f598e77 into main Oct 31, 2024
13 checks passed
@shortcuts shortcuts deleted the fix/javascript-import-dist branch October 31, 2024 13:01
algolia-bot added a commit that referenced this pull request Oct 31, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Oct 31, 2024
algolia/api-clients-automation#4060

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants