Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): deleteBy returns an updatedAt response [skip-bc] #4107

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-3213

Changes included:

closes algolia/algoliasearch-client-python#575

delete_by returns an updatedAt response, not a deletedAt

@shortcuts shortcuts self-assigned this Nov 15, 2024
@shortcuts shortcuts requested a review from a team as a code owner November 15, 2024 10:00
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 8a54e50cd0ae1fa73cf1397c61e504db73f0055a
🍃 Generated commit 3da5b3bd8db50d4bf20a0421cba922a4c391049b
🌲 Generated branch generated/fix/delete-by-response
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1636
javascript 1620
php 1508
csharp 1242
java 1106
python 1007
ruby 881
swift 756

@shortcuts shortcuts changed the title fix(specs): deleteBy returns an updatedAt response fix(specs): deleteBy returns an updatedAt response [skip-bc] Nov 15, 2024
@shortcuts shortcuts enabled auto-merge (squash) November 15, 2024 11:24
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shortcuts shortcuts merged commit ab0b923 into main Nov 15, 2024
28 checks passed
@shortcuts shortcuts deleted the fix/delete-by-response branch November 15, 2024 11:44
algolia-bot added a commit that referenced this pull request Nov 15, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4107

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
millotp pushed a commit that referenced this pull request Nov 18, 2024
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: onfusing error message in deleteBy operation & unclear migration path from v3 to v4
3 participants