Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): change dist folder and bump #4113

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore(scripts): change dist folder and bump #4113

merged 1 commit into from
Nov 15, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Nov 15, 2024

🧭 What and Why

The js release failed because tsc changed the output dir for some reason.
I tried releasing manually and failed so I had to bump all version a patch up and release on top of the buggy version.
This is very dirty and I have learned a lesson not to release on a friday night

@millotp millotp self-assigned this Nov 15, 2024
@millotp millotp requested a review from a team as a code owner November 15, 2024 18:36
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 15, 2024

✔️ Code generated!

Name Link
🪓 Triggered by b44e39169c99553912e0fe68127e439bd5512a1d
🍃 Generated commit 293bab31043feca0cced70a6a275e635f4d389ba
🌲 Generated branch generated/chore/js-release
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1663
go 1661
php 1489
csharp 1278
java 1131
python 977
ruby 891
swift 728

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok so because there's only one file now it's not worth a dir anymore?

@millotp
Copy link
Collaborator Author

millotp commented Nov 15, 2024

I didn't find the deleted file but yes that might be the reason

@millotp millotp merged commit 0787a3d into main Nov 15, 2024
28 checks passed
@millotp millotp deleted the chore/js-release branch November 15, 2024 19:45
algolia-bot added a commit that referenced this pull request Nov 15, 2024
… ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 15, 2024
algolia/api-clients-automation#4113

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
millotp added a commit that referenced this pull request Nov 18, 2024
… ci]

Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants