Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): default authMode to WithinHeaders for Composition Client #4129

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

e-krebs
Copy link
Contributor

@e-krebs e-krebs commented Nov 18, 2024

🧭 What and Why

🎟 JIRA Ticket: EMERCH-1759

Changes included:

  • default authMode to WithinHeaders for Composition Client
  • standardize variable name

🧪 Test

@e-krebs e-krebs self-assigned this Nov 18, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Nov 18, 2024

✔️ Code generated!

Name Link
🪓 Triggered by f90074b134f5f9aeff068c1572cfad45b5e1b1ea
🍃 Generated commit 7a9f5ac94eb48ef30dff0a76a3e78ff287085c5a
🌲 Generated branch generated/feat/composition-default-authmode
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 1655
javascript 1596
php 1543
csharp 1150
java 1096
python 1016
ruby 850
swift 767

@e-krebs e-krebs requested a review from shortcuts November 18, 2024 17:28
@e-krebs e-krebs marked this pull request as ready for review November 18, 2024 17:35
@e-krebs e-krebs requested a review from a team as a code owner November 18, 2024 17:35
@e-krebs e-krebs requested a review from Fluf22 November 18, 2024 17:35
@shortcuts shortcuts enabled auto-merge (squash) November 18, 2024 20:26
@shortcuts shortcuts merged commit 08669e2 into main Nov 18, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/composition-default-authmode branch November 18, 2024 20:43
algolia-bot added a commit that referenced this pull request Nov 18, 2024
…#4129) (generated) [skip ci]

Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Nov 18, 2024
… (generated)

algolia/api-clients-automation#4129

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com>
Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants