feat(specs): update composition specs according to upcoming API changes #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
e-krebs
changed the title
e-krebs
force-pushed
the
feat/composition-schema-update
branch
2 times, most recently
from
4ede08f to
5febb5c
Compare
gavinwade12
reviewed
Dec 13, 2024
shortcuts
reviewed
Dec 17, 2024
|
@shortcuts I previously mis-implemented the search response, it is now fixed (cf. doc linked in description for the correct shape) |
shortcuts
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
would be great to have more concrete e2e so we can assert those changes, can be done later though
algolia-bot
added a commit
that referenced
this pull request
Dec 18, 2024
…es (#4234) (generated) [skip ci] Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Dec 18, 2024
…es (generated) algolia/api-clients-automation#4234 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Emmanuel Krebs <e-krebs@users.noreply.github.com> Co-authored-by: shortcuts <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Update composition specs according to upcoming API changes
https://algolia.atlassian.net/wiki/spaces/CMP/pages/5556273184/DD+-+Composition+API+updates
🎟 JIRA Ticket: EMERCH-1797