Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): add renderingContent to search response #787

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix(specs): add renderingContent to search response #787

merged 1 commit into from
Jul 5, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 5, 2022

🧭 What and Why

renderingContent is sometimes returned in the SearchResponse, but not documented.

@millotp millotp requested a review from a team July 5, 2022 09:53
@millotp millotp self-assigned this Jul 5, 2022
@millotp millotp requested review from damcou and shortcuts and removed request for a team July 5, 2022 09:53
@netlify
Copy link

netlify bot commented Jul 5, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fe1c810
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62c40a2815656a000f539ba3
😎 Deploy Preview https://deploy-preview-787--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 5, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@millotp millotp enabled auto-merge (squash) July 5, 2022 09:55
@millotp millotp merged commit 5a49984 into main Jul 5, 2022
@millotp millotp deleted the fix/search-response branch July 5, 2022 09:57
@millotp millotp mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@damcou damcou Awaiting requested review from damcou damcou is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@millotp millotp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@millotp @algolia-bot @shortcuts