Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RefinementList createURL breaks in 2.2.0 #1849

Closed
zackify opened this issue Jan 17, 2017 · 0 comments
Closed

RefinementList createURL breaks in 2.2.0 #1849

zackify opened this issue Jan 17, 2017 · 0 comments
Labels
Type: Bug

Comments

@zackify
Copy link

zackify commented Jan 17, 2017 •
edited
Loading

Browsing the changelog myself, if I see the problem I'll comment here with an update.

Edit: Looks like onSearchStateChanged is never being called either ?

Bug: What is the current behavior?
Calling createURL on a refinement just returns # in 2.2.0, revert back to 2.1.0, works fine.

Bug: What is the expected behavior?
For it to work :)

What project are you opening an issue for?

  • react-instantsearch

Edit 2, might want some tests that check for injected variables from createInstanteSearch? :)
zackify referenced this issue Jan 17, 2017
@bobylito
fix(Instantsearch): Update all props on InstantSearch (#1828)
2ed9b49 
* fix(createInstantSearch): new credentials creates a new client. Previously was creating a new client at each render.

* fix(isManager): implement update of client
* feat(SearchParameters): Move InstantSearch config to <Configure/>
Also:
 - fix the indexName property to be able to update it.
 - small refactoring to explicitely define the props of
createInstantSearch
 - update the doc accordingly
zackify added a commit to zackify/instantsearch.js that referenced this issue Jan 17, 2017
@zackify
Fix bug with no props being passed down in 2.2.0, closes algolia#1849
cbdaa26
@zackify zackify mentioned this issue Jan 17, 2017
Closed
@bobylito bobylito mentioned this issue Jan 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvo @zackify