Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfiniteHits Load More button translation #2047

Closed
kolyasya opened this issue Mar 14, 2017 · 3 comments
Closed

InfiniteHits Load More button translation #2047

kolyasya opened this issue Mar 14, 2017 · 3 comments
Assignees
@iam4x
Labels
Difficulty: Easy Type: Bug

Comments

@kolyasya
Copy link

Hello, it seems like there is no way to change text in Load More button for InfiniteHits component?

There is no Translation Keys in docs

And I checked source code, it seems like Load More is hardcoded
@Haroenv
Copy link
Contributor

Haroenv commented Mar 14, 2017

Thanks a lot for your report! This can be fixed quite fast. Do you want to do a pull request?

@kolyasya
Copy link
Author

@Haroenv sorry, I'm not familiar with your project codebase :(

@Haroenv
Copy link
Contributor

Haroenv commented Mar 14, 2017

No problem, we will get it fixed!

@iam4x iam4x self-assigned this Mar 14, 2017
iam4x added a commit that referenced this issue Mar 14, 2017
@iam4x
fix(InfiniteHits): provide translation key for Load More
18e8e5d 
see: #2047
@iam4x iam4x mentioned this issue Mar 14, 2017
Merged
@vvo vvo closed this as completed in #2048 Mar 16, 2017
vvo pushed a commit that referenced this issue Mar 16, 2017
@vvo
fix(InfiniteHits): provide translation key for Load More (#2048)
6130bf2 
see: #2047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iam4x iam4x

Labels
Difficulty: Easy Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bobylito @iam4x @kolyasya @Haroenv