-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core(instantsearch-manager): provide a fn for setting SearchParameters #1471
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,19 @@ import {omit, has} from 'lodash'; | |
|
||
import {shallowEqual, getDisplayName} from './utils'; | ||
|
||
/** | ||
* @typedef {object} ConnectorDescription | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am unsure on the context of this addition, can you detail it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I started exploring the possibility of writing the widget, and didn't have a proper documentation for the object that could be passed to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure, if it currently does not have any output in our documentation website I would say we do not need it for now. |
||
* @property {string} displayName - the displayName used by the wrapper | ||
* @property {function} refine - a function to filter the local state | ||
* @property {function} getSearchParameters - function transforming the local state to a SearchParameters | ||
* @property {function} getMetadata - metadata of the widget | ||
* @property {function} transitionState - hook after the state has changed | ||
* @property {function} getProps - transform the state into props passed to the wrapped component. | ||
* Receives (props, widgetStates, searchState, metadata) and returns the local state. | ||
* @property {object} propTypes - PropTypes forwarded to the wrapped component. | ||
* @property {object} defaultProps - default values for the props | ||
*/ | ||
|
||
/** | ||
* Connectors are the HOC used to transform React components | ||
* into InstantSearch widgets. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the "Typical use case"