Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sort function): more info on expected function param #1524

Merged
merged 2 commits into from
Nov 8, 2016

Conversation

olance
Copy link
Contributor

@olance olance commented Nov 8, 2016

This is a small update of our docs to indicate that the function option for sortBy in the menu, hierarchicalMenu and refinementList widgets is the same as the compareFunction param for the standard Javascript Array.prototype.sort.

Olivier Lance added 2 commits November 8, 2016 13:44
…ortBy` options in menu, hierarchicalMenu and refinementList widgets
…n the menu, hierarchicalMenu and refinementList widgets
@algobot
Copy link
Contributor

algobot commented Nov 8, 2016

By analyzing the blame information on this pull request, we identified @PLNech, @bobylito and @vvo to be potential reviewers

@vvo
Copy link
Contributor

vvo commented Nov 8, 2016

THX

@vvo vvo merged commit fe5fd8d into master Nov 8, 2016
@vvo vvo deleted the docs/sort-function branch November 8, 2016 13:15
@vvo
Copy link
Contributor

vvo commented Nov 8, 2016

will be live in the coming minutes

vvo pushed a commit that referenced this pull request Nov 14, 2016
* Adds information in the docs about the expected function param for `sortBy` options in menu, hierarchicalMenu and refinementList widgets

* Update of the generated docs with details on the sort function used in the menu, hierarchicalMenu and refinementList widgets
vvo added a commit that referenced this pull request Nov 14, 2016
* docs(sort function): more info on expected function param (#1524)

* Adds information in the docs about the expected function param for `sortBy` options in menu, hierarchicalMenu and refinementList widgets

* Update of the generated docs with details on the sort function used in the menu, hierarchicalMenu and refinementList widgets

* chore(lint): fix lint in recent update

* chore(deps): upgrade all deps 2016-11-14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants